[webkit-reviews] review denied: [Bug 67762] Crashes in WebCore::ReplaceSelectionCommand::doApply : [Attachment 106700] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 7 23:54:05 PDT 2011

Kent Tamura <tkent at chromium.org> has denied Shinya Kawanaka
<shinyak at google.com>'s request for review:
Bug 67762: Crashes in WebCore::ReplaceSelectionCommand::doApply

Attachment 106700: Patch

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=106700&action=review

> LayoutTests/ChangeLog:11
> +	   * editing/inserting/insert-replaceselection-crash-expected.txt:
> +	   * editing/inserting/insert-replaceselection-crash.html: Added.

It's better, but we had better describe a test case, rather than a crash
How about insert-without-enclosing-block.html?

> Source/WebCore/ChangeLog:10
> +	   Test: editing/inserting/insert-67668-crash.html

Need to update.

More information about the webkit-reviews mailing list