[webkit-reviews] review denied: [Bug 67711] Web Inspector: [REGRESSION] Clear console shortcut Ctrl + L broken : [Attachment 106590] [PATCH] Suggested fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 7 23:44:26 PDT 2011

Yury Semikhatsky <yurys at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 67711: Web Inspector: [REGRESSION] Clear console shortcut Ctrl + L broken

Attachment 106590: [PATCH] Suggested fix

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=106590&action=review

> Source/WebCore/inspector/front-end/ConsoleView.js:495
>	   this._shortcuts[shortcutK.key].isMacOnly = true;

I'd suggest you get rid of the isMacOnly flag and set this handler only if
current platform is Mac, this way you'll be able to share the handler.

More information about the webkit-reviews mailing list