[webkit-reviews] review granted: [Bug 44081] Add standalone script that filters the output of build-webkit to be more human-readable : [Attachment 106679] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 7 21:30:27 PDT 2011


Daniel Bates <dbates at webkit.org> has granted Matthew Delaney
<mdelaney at apple.com>'s request for review:
Bug 44081: Add standalone script that filters the output of build-webkit to be
more human-readable
https://bugs.webkit.org/show_bug.cgi?id=44081

Attachment 106679: Patch
https://bugs.webkit.org/attachment.cgi?id=106679&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=106679&action=review


Colors in the air. Oh, everywhere. It comes in colors!

> Tools/Scripts/filter-build-webkit:113
> +open(OUTPUT_HANDLE, ">$outputPath") or die "Failed to open $outputPath";

Nit: I suggest appending the error message (in $!) to the die() message so as
to provide a more descriptive reason for the failure. So, I would write this
line as:

open(OUTPUT_HANDLE, ">$outputPath") or die "Failed to open $outputPath: $!";

> Tools/Scripts/filter-build-webkit:115
> +    open(UNFILTERED_OUTPUT_HANDLE, ">$unfilteredOutputPath") or die "Failed
to open $unfilteredOutputPath";

Nit: Similarly, I would append the error message (in $!) to the die() message.


More information about the webkit-reviews mailing list