[webkit-reviews] review granted: [Bug 67749] AudioBufferSourceNode must validate AudioBuffer in .buffer attribute setter : [Attachment 106677] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 7 20:30:56 PDT 2011


Kenneth Russell <kbr at google.com> has granted Chris Rogers
<crogers at google.com>'s request for review:
Bug 67749: AudioBufferSourceNode must validate AudioBuffer in .buffer attribute
setter
https://bugs.webkit.org/show_bug.cgi?id=67749

Attachment 106677: Patch
https://bugs.webkit.org/attachment.cgi?id=106677&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=106677&action=review


Looks fine; one minor comment.

> Source/WebCore/webaudio/AudioBufferSourceNode.cpp:341
> +	       return false; // the current implementation handles only mono
and stereo playback

Do you want to add a FIXME here?


More information about the webkit-reviews mailing list