[webkit-reviews] review granted: [Bug 67739] adjustRectForColumns is slow when a huge # of columns are involved : [Attachment 106659] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Dave Hyatt <hyatt at apple.com>'s request for review:
Bug 67739: adjustRectForColumns is slow when a huge # of columns are involved
https://bugs.webkit.org/show_bug.cgi?id=67739

Attachment 106659: Patch
https://bugs.webkit.org/attachment.cgi?id=106659&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=106659&action=review


>> Source/WebCore/rendering/RenderBlock.cpp:4622
>> +	if (colHeight == 0)
> 
> Tests for true/false, null/non-null, and zero/non-zero should all be done
without equality comparisons.  [readability/comparison_to_zero] [5]

That’s right.