[webkit-reviews] review requested: [Bug 67743] AX: some popup buttons not announced by VoiceOver : [Attachment 106661] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 7 15:41:59 PDT 2011
chris fleizach <cfleizach at apple.com> has asked for review:
Bug 67743: AX: some popup buttons not announced by VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=67743
Attachment 106661: patch
https://bugs.webkit.org/attachment.cgi?id=106661&action=review
------- Additional Comments from chris fleizach <cfleizach at apple.com>
In the patch, I remove this block
if (node && node->hasTagName(buttonTag))
because it's duplicated only a few lines above that.
This is removed
- if (cssBox && cssBox->isRenderButton())
- return toRenderButton(m_renderer)->text();
because it causes the text to be duplicated as the title.
More information about the webkit-reviews
mailing list