[webkit-reviews] review requested: [Bug 66887] CSS rules not being applied when a hidden field is inserted between an input[type=checkbox] and a label : [Attachment 106651] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 7 15:03:23 PDT 2011


Kulanthaivel Palanichamy <kulanthaivel at codeaurora.org> has asked  for review:
Bug 66887: CSS rules not being applied when a hidden field is inserted between
an input[type=checkbox] and a label
https://bugs.webkit.org/show_bug.cgi?id=66887

Attachment 106651: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=106651&action=review

------- Additional Comments from Kulanthaivel Palanichamy
<kulanthaivel at codeaurora.org>
More cleaner version.

This patch removes childrenAffectedByDirectAdjacentRules parent flag and forces
style calculation for adjacent sibling if the current element is affected by
direct adjacent rules irrespective of whether the adjacent sibling is affected
by direct adjacent rules or not. This change is needed to make sure that the
adjacent sibling's style is recalculated when there is no renderer attached to
the adjacent sibling but it may be affected by direct adjacent rules at that
moment.


More information about the webkit-reviews mailing list