[webkit-reviews] review granted: [Bug 67723] Fixed Layout Mode should be adjustable from layoutTestController for testing on Chromium platforms : [Attachment 106637] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 7 14:24:36 PDT 2011
Adam Barth <abarth at webkit.org> has granted Fady Samuel <fsamuel at chromium.org>'s
request for review:
Bug 67723: Fixed Layout Mode should be adjustable from layoutTestController for
testing on Chromium platforms
https://bugs.webkit.org/show_bug.cgi?id=67723
Attachment 106637: Patch
https://bugs.webkit.org/attachment.cgi?id=106637&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=106637&action=review
Why do you have two copies of fixed-layout-360x240-expected.png ? They have
the same sha1. Presumably we can remove
LayoutTests/platform/chromium-linux/fast/repaint/fixed-layout-360x240-expected.
png.
> LayoutTests/fast/repaint/fixed-layout-360x240.html:8
> + window.layoutTestController.enableFixedLayoutMode(true);
> + window.layoutTestController.setFixedLayoutSize(360, 240);
Does this test need to be skipped on non-chromium platforms?
More information about the webkit-reviews
mailing list