[webkit-reviews] review denied: [Bug 67651] Move Element.contains to Node : [Attachment 106635] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 7 14:16:55 PDT 2011

Darin Adler <darin at apple.com> has denied Erik Arvidsson <arv at chromium.org>'s
request for review:
Bug 67651: Move Element.contains to Node

Attachment 106635: Patch

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=106635&action=review

> Source/WebCore/dom/Node.cpp:1340
> +    if (!node || !this)
>	   return false;

It's not legal to call a member function on a null pointer. So it's never
correct to check this for 0. This change should not be made. We don’t want this
to be the one function in the entire WebKit project doing this.

More information about the webkit-reviews mailing list