[webkit-reviews] review denied: [Bug 66887] CSS rules not being applied when a hidden field is inserted between an input[type=checkbox] and a label : [Attachment 106612] Proposed patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Kulanthaivel Palanichamy
<kulanthaivel at codeaurora.org>'s request for review:
Bug 66887: CSS rules not being applied when a hidden field is inserted between
an input[type=checkbox] and a label
https://bugs.webkit.org/show_bug.cgi?id=66887

Attachment 106612: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=106612&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
This patch isn't quite right. Here are the issues I see:

(1) What's the point of keeping childrenAffectedByDirectAdjacentRules once you
change it to track a bool in the children instead? You shouldn't need both
flags.

(2) If you eliminate the parent flag, then what you're really patching is
"forceCheckOfNextElementSibling". You can basically set that to true if the
next sibling is affected by direct adjacent rules. Otherwise you don't have to
do anything.

Let me know if I'm mistaken, but it sure looks like you don't need to keep
around the other flag any longer with this change.