[webkit-reviews] review denied: [Bug 67705] [EFL] Add missing *void* parameter : [Attachment 106573] Proposed Patch

[bugzilla-daemon at webkit.org]

Lucas De Marchi <demarchi at webkit.org> has denied Gyuyoung Kim
<gyuyoung.kim at samsung.com>'s request for review:
Bug 67705: [EFL] Add missing *void* parameter
https://bugs.webkit.org/show_bug.cgi?id=67705

Attachment 106573: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=106573&action=review

------- Additional Comments from Lucas De Marchi <demarchi at webkit.org>
void parameter is not a coding-style thing.

In C, a function with no parameters is achieved by putting a void keyword in
the parameter's list. Without any keywords it's considered a function that can
receive any number of parameters (the equivalent of writing (...)  in C++).

Although this is a valid function prototype in C++, it's not a the preferred
way of doing it. Since these are all C++ files and header that is included only
by C++ sources, there's no point in adding them at all.

See: http://en.wikipedia.org/wiki/Void_type

For the reasons pointed out above, my informal r-.