[webkit-reviews] review granted: [Bug 67669] Null ptr crash in RenderScrollbar::updateScrollbarParts : [Attachment 106481] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Abhishek Arya
<inferno at chromium.org>'s request for review:
Bug 67669: Null ptr crash in RenderScrollbar::updateScrollbarParts
https://bugs.webkit.org/show_bug.cgi?id=67669

Attachment 106481: Patch
https://bugs.webkit.org/attachment.cgi?id=106481&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=106481&action=review


So I think this is at least not harmful, so R=me.  I really don't understand
how this could help with the crash that you cite, however.

> Source/WebCore/ChangeLog:7
> +
> +	   Reviewed by NOBODY (OOPS!).
> +

describe the change and why you haven't added tests

> Source/WebCore/rendering/RenderScrollbar.cpp:199
> +	   if (owningRenderer())
> +	       owningRenderer()->setChildNeedsLayout(true);

this should be written more like
if (RenderBox* box = owningRenderer())
    box->setChildNeedsLayout(true)

this is more common in webkit and more efficient in the case where
owningRenderer() is expensive