[webkit-reviews] review canceled: [Bug 67094] [Qt][WK2] Qt layer should be hardened against C API versioning in the sense of build failures : [Attachment 106408] proposed fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 7 01:15:27 PDT 2011


Balazs Kelemen <kbalazs at webkit.org> has canceled Balazs Kelemen
<kbalazs at webkit.org>'s request for review:
Bug 67094: [Qt][WK2] Qt layer should be hardened against C API versioning in
the sense of build failures
https://bugs.webkit.org/show_bug.cgi?id=67094

Attachment 106408: proposed fix
https://bugs.webkit.org/attachment.cgi?id=106408&action=review

------- Additional Comments from Balazs Kelemen <kbalazs at webkit.org>
It's not correct. Since we always build against trunk we should use the current
version of the client structures. This way we can notice functional changes
that affect us. Another argument is that WebKit::APIClient except the version
number and the layout of the structure is matching.


More information about the webkit-reviews mailing list