[webkit-reviews] review granted: [Bug 67694] Value profling and execution count profiling is performed even for code that cannot be optimized : [Attachment 106545] the patch

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 67694: Value profling and execution count profiling is performed even for
code that cannot be optimized
https://bugs.webkit.org/show_bug.cgi?id=67694

Attachment 106545: the patch
https://bugs.webkit.org/attachment.cgi?id=106545&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
Seems reasonable.  We could probably save the extra pass if we wanted (track at
the point opcodes are added to the byte code when unsupported ones are added),
but I guess this is hardly an important cost.

Looks like you need to fix windows .defs file & also the alphabetical sorting
issues (ascii ordering, so all caps are < all lowercase).