[webkit-reviews] review denied: [Bug 64546] Redrawing dirty parts of a large table is very slow : [Attachment 106453] Changes and tests.

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Konstantin Shcheglov
<scheglov at google.com>'s request for review:
Bug 64546: Redrawing dirty parts of a large table is very slow
https://bugs.webkit.org/show_bug.cgi?id=64546

Attachment 106453: Changes and tests.
https://bugs.webkit.org/attachment.cgi?id=106453&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=106453&action=review


> Source/WebCore/rendering/RenderTable.cpp:434
> +    if (!m_collapsedBordersValid) {
> +	   m_collapsedBordersValid = true;

This should use an early return.

> Source/WebCore/rendering/RenderTable.h:263
> +    CollapsedBorderValues m_collapsedBorders;

This seems like it is making all RenderTables much much bigger
(sizeof(CollapsedBorderValues) * 100).	Why is that ok?

> Source/WebCore/rendering/RenderTableCol.cpp:50
> +    if (table() && style() && style()->border() != newStyle->border())
> +	       table()->invalidateCollapsedBorders();

The indentation is wrong here.

> Source/WebCore/rendering/RenderTableSection.cpp:83
> +    if (table() && style() && style()->border() != newStyle->border())
> +	       table()->invalidateCollapsedBorders();

The indentation is wrong here.