[webkit-reviews] review granted: [Bug 67678] Remove window.HTMLBlockquoteElement per HTML5 (and DOM Core 1) : [Attachment 106497] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 6 15:44:24 PDT 2011

Darin Adler <darin at apple.com> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 67678: Remove window.HTMLBlockquoteElement per HTML5 (and DOM Core 1)

Attachment 106497: Patch

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=106497&action=review

A quick check around Apple didn’t show any examples of software using the
DOMHTMLBlockquoteElement class from Objective-C. If there was any, we would
need to find a way to keep that working.

> Source/WebCore/html/HTMLQuoteElement.cpp:47
> -    document()->setUsesBeforeAfterRules(true);
> +    if (hasTagName(qTag))
> +	   document()->setUsesBeforeAfterRules(true);

It occurs to me that this compiles in assumptions about the html.css file.

More information about the webkit-reviews mailing list