[webkit-reviews] review denied: [Bug 67621] [chromium] REGRESSION(94353): requestAnimationFrame not throttled in compositing path : [Attachment 106452] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Sep 6 11:42:48 PDT 2011
James Robinson <jamesr at chromium.org> has denied Nat Duca <nduca at chromium.org>'s
request for review:
Bug 67621: [chromium] REGRESSION(94353): requestAnimationFrame not throttled in
compositing path
https://bugs.webkit.org/show_bug.cgi?id=67621
Attachment 106452: Patch
https://bugs.webkit.org/attachment.cgi?id=106452&action=review
------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=106452&action=review
> Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:91
> + commitIfNeeded(false);
actually we don't want to do layout here either. it's the responsibility of the
caller to WebWidget::paint() to call animateAndLayout() before calling this
function
> Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:237
> + if (!alreadyCalledLayout)
> + m_layerTreeHost->animateAndLayout(frameBeginTime);
i think you can just delete this completely
More information about the webkit-reviews
mailing list