[webkit-reviews] review granted: [Bug 54611] Elements with position:absolute don't move to correct position after images load : [Attachment 106285] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Robert Hogan
<robert at webkit.org>'s request for review:
Bug 54611: Elements with position:absolute don't move to correct position after
images load
https://bugs.webkit.org/show_bug.cgi?id=54611

Attachment 106285: Patch
https://bugs.webkit.org/attachment.cgi?id=106285&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=106285&action=review


> LayoutTests/fast/block/positioning/absolute-layout-after-image-load.html:3
> +<meta http-equiv="Content-Style-Type" content="text/css">

Remove

>
LayoutTests/fast/block/positioning/resources/absolute-layout-after-image-load-2
.html:3
> +<meta http-equiv="Content-Style-Type" content="text/css">

Remove.

>
LayoutTests/fast/block/positioning/resources/absolute-layout-after-image-load-2
.html:17
> +	   layoutTestController.waitUntilDone();

I don't think you need these in the loaded resource. Those in the first test
page are enough.

> Source/WebCore/ChangeLog:16
> +	   The reduced case for this bug is:
> +
> +	   <style type="text/css">
> +	   .footnote .label  {position: absolute; right: 84%; text-align:
right;}
> +	   </style>
> +	   <img
src="http://www.gutenberg.org/files/33439/33439-h/images/cover.jpg">
> +	   <div class="footnote"><a id="Footnote_1"></a><a
href="resources/greenbox.png"><div class="label">[1]</div></a></div>

It's not necessary to put this in the changelog.