[webkit-reviews] review granted: [Bug 67567] REGRESSION (Safari 5.1 - ToT): File input retains its file icon when the value is reset : [Attachment 106392] Patch 2

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 67567: REGRESSION (Safari 5.1 - ToT): File input retains its file icon when
the value is reset
https://bugs.webkit.org/show_bug.cgi?id=67567

Attachment 106392: Patch 2
https://bugs.webkit.org/attachment.cgi?id=106392&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=106392&action=review


Thanks for fixing this -- and the fix is right. I have a small naming nit.

> Source/WebCore/html/HTMLInputElement.cpp:1127
> +void HTMLInputElement::setValueInternal(const String& sanitizedValue, bool
sendChangeEvent)

This should be something like valueChanged.