[webkit-reviews] review requested: [Bug 67612] Protect against incorrect Element::fast*Attribute() usage. : [Attachment 106406] Proposed patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 6 04:50:31 PDT 2011


Andreas Kling <kling at webkit.org> has asked  for review:
Bug 67612: Protect against incorrect Element::fast*Attribute() usage.
https://bugs.webkit.org/show_bug.cgi?id=67612

Attachment 106406: Proposed patch v2
https://bugs.webkit.org/attachment.cgi?id=106406&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
Second attack!

- Put the relevant things in !NDEBUG blocks.
- Moved animatable property check to "static bool
SVGElement::isAnimatableAttribute(const QualifiedName&)" where we use a static
hashset as suggested by Nikolas.
- Added comment in Element.h about getClassAttribute().


More information about the webkit-reviews mailing list