[webkit-reviews] review denied: [Bug 67612] Protect against incorrect Element::fast*Attribute() usage. : [Attachment 106352] Proposed patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has denied  review:
Bug 67612: Protect against incorrect Element::fast*Attribute() usage.
https://bugs.webkit.org/show_bug.cgi?id=67612

Attachment 106352: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=106352&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=106352&action=review


> Source/WebCore/dom/Element.cpp:2008
> +bool Element::fastAttributeLookupAllowed(const QualifiedName& name) const
> +{
> +    if (name == HTMLNames::styleAttr)
> +	   return false;

I'm revoking Dirks r+. This needs to be a static hashset, this is way too
inefficient.