[webkit-reviews] review denied: [Bug 40351] [chromium] Can't handle deletion of characters beyond U+10000. : [Attachment 106334] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Shinya Kawanaka
<shinyak at google.com>'s request for review:
Bug 40351: [chromium] Can't handle deletion of characters beyond U+10000.
https://bugs.webkit.org/show_bug.cgi?id=40351

Attachment 106334: Patch
https://bugs.webkit.org/attachment.cgi?id=106334&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=106334&action=review


>> Source/WebCore/rendering/RenderText.cpp:1671
>> +#if PLATFORM(MAC) || defined(OS_MACOSX)
> 
> I don't know if all other ports want this behavior when running on OS X,
although I would certainly encourage them to.

OS_MACOSX is a macro used only in Chromium, and we should not use it here. We
should write

#if PLATFORM(MAC) || PLATFORM(CHROMIUM) && OS(MAC_OS_X)

or

#if OS(DARWIN)
if you'd like to include iOS and Qt/Mac.