[webkit-reviews] review granted: [Bug 67612] Protect against incorrect Element::fast*Attribute() usage. : [Attachment 106352] Proposed patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has granted Andreas Kling <kling at webkit.org>'s
request for review:
Bug 67612: Protect against incorrect Element::fast*Attribute() usage.
https://bugs.webkit.org/show_bug.cgi?id=67612

Attachment 106352: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=106352&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=106352&action=review


Some notes. But looks good in general.

> Source/WebCore/svg/SVGAnimationElement.cpp:256
> +    if (hasAttribute(SVGNames::valuesAttr))

All attributes of SMILElements are not animatable. Can you use fastHasAttribute
for it?

> Source/WebCore/svg/animation/SVGSMILElement.cpp:543
> -    return fastGetAttribute(XLinkNames::hrefAttr);
> +    return getAttribute(XLinkNames::hrefAttr);

Ditto with fastGetAttribute.