[webkit-reviews] review denied: [Bug 67584] [Chromium] Add WebSandboxSupport and WebThemeEngine for Android. : [Attachment 106310] Proposed patch 3.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 5 13:20:55 PDT 2011

Steve Block <steveblock at google.com> has denied	review:
Bug 67584: [Chromium] Add WebSandboxSupport and WebThemeEngine for Android.

Attachment 106310: Proposed patch 3.

------- Additional Comments from Steve Block <steveblock at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=106310&action=review

> Source/WebKit/chromium/public/android/WebSandboxSupport.h:38
> +class WebSandboxSupport {

As discussed, I'm very hesitant about adding an empty class. You should either
provide an explanation of why it's empty, a bug for when it will be filled out,
or ideally avoid the need for it altogether.

More information about the webkit-reviews mailing list