[webkit-reviews] review denied: [Bug 67610] Web Inspector: disable popover when a mouse button is pressed : [Attachment 106347] patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 67610: Web Inspector: disable popover when a mouse button is pressed
https://bugs.webkit.org/show_bug.cgi?id=67610

Attachment 106347: patch
https://bugs.webkit.org/attachment.cgi?id=106347&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=106347&action=review


> Source/WebCore/inspector/front-end/Popover.js:205
> +	   this._mouseButtonsState &= ~(1 << event.button);

I am still parsing it... What is happening?

> Source/WebCore/inspector/front-end/Popover.js:-227
> -    _handleMouseAction: function(event, isMouseDown)

I'd say we should keep Timeline's logic of immediately showing popover on click
and not reduce its timeout.