[webkit-reviews] review granted: [Bug 67606] [Qt][WK2] Make TiledDrawingArea request tiles only in the direction the viewport is panned to. : [Attachment 106343] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has granted Jocelyn Turcotte
<jocelyn.turcotte at nokia.com>'s request for review:
Bug 67606: [Qt][WK2] Make TiledDrawingArea request tiles only in the direction
the viewport is panned to.
https://bugs.webkit.org/show_bug.cgi?id=67606

Attachment 106343: Patch
https://bugs.webkit.org/attachment.cgi?id=106343&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=106343&action=review


Awesome stuff. Not sure if someone else (kenneth?) wants to take a look at
these TBS patches as well, otherwise r=me.

> Source/WebCore/ChangeLog:18
> +	   (WebCore::TiledBackingStore::setCoverAreaFocusVector):

The name "focus" has a bit of a keyboard connotation.
How about trajectory? (not sure this is that important, though)

> Source/WebCore/platform/graphics/TiledBackingStore.cpp:305
> +    // Inflates to both sides, so divide inflate delta by 2

Period at end of sentence.