[webkit-reviews] review granted: [Bug 67056] Logic from HTMLElement::deprecatedCreateContextualFragment moved into Range::createContextualFragment function : [Attachment 106308] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Kaustubh Atrawalkar
<kaustubh at motorola.com>'s request for review:
Bug 67056: Logic from HTMLElement::deprecatedCreateContextualFragment moved
into Range::createContextualFragment function
https://bugs.webkit.org/show_bug.cgi?id=67056

Attachment 106308: Patch
https://bugs.webkit.org/attachment.cgi?id=106308&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=106308&action=review


> Source/WebCore/dom/Range.cpp:1132
> +    if (htmlElement->hasLocalName(colTag) ||
htmlElement->hasLocalName(colgroupTag) ||
htmlElement->hasLocalName(framesetTag)
> +	   || htmlElement->hasLocalName(headTag) ||
htmlElement->hasLocalName(styleTag) || htmlElement->hasLocalName(titleTag))
> +	   return 0;

Maybe we should consider using HashMap in the future.