[webkit-reviews] review granted: [Bug 67056] Logic from HTMLElement::deprecatedCreateContextualFragment moved into Range::createContextualFragment function : [Attachment 106307] Final Updated patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Sep 4 23:26:46 PDT 2011
Ryosuke Niwa <rniwa at webkit.org> has granted Kaustubh Atrawalkar
<kaustubh at motorola.com>'s request for review:
Bug 67056: Logic from HTMLElement::deprecatedCreateContextualFragment moved
into Range::createContextualFragment function
https://bugs.webkit.org/show_bug.cgi?id=67056
Attachment 106307: Final Updated patch
https://bugs.webkit.org/attachment.cgi?id=106307&action=review
------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=106307&action=review
sorry, I didn't catch one nit.
> Source/WebCore/dom/Range.cpp:1139
> + return 0; // FIXME: We should propagate a syntax error exception
out here.
Nit: wrong indentation.
More information about the webkit-reviews
mailing list