[webkit-reviews] review granted: [Bug 67056] Logic from HTMLElement::deprecatedCreateContextualFragment moved into Range::createContextualFragment function : [Attachment 106290] Patch after getting in Ryosuke's comments

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Kaustubh Atrawalkar
<kaustubh at motorola.com>'s request for review:
Bug 67056: Logic from HTMLElement::deprecatedCreateContextualFragment moved
into Range::createContextualFragment function
https://bugs.webkit.org/show_bug.cgi?id=67056

Attachment 106290: Patch after getting in Ryosuke's comments
https://bugs.webkit.org/attachment.cgi?id=106290&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=106290&action=review


> Source/WebCore/dom/Range.cpp:1145
> +	       Node* firstChild = element->firstChild();
> +	       if (firstChild)
> +		   nextNode = firstChild;

firstChild can be declared inside if to limit the scope as in:
if (Node* firstChild = element->firstChild())
    nextNode = firstChild;

> Source/WebCore/editing/markup.cpp:687
>      // We use a fake body element here to trick the HTML parser to using the

> -    // InBody insertion mode.  Really, all this code is wrong and need to be

> -    // changed not to use deprecatedCreateContextualFragment.
> +    // InBody insertion mode.

The entire comment seems to fit in one line.