[webkit-reviews] review granted: [Bug 67576] [Chromium] Add mutliple to WebPopupMenuInfo for Android : [Attachment 106284] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Adam Barth
<abarth at webkit.org>'s request for review:
Bug 67576: [Chromium] Add mutliple to WebPopupMenuInfo for Android
https://bugs.webkit.org/show_bug.cgi?id=67576

Attachment 106284: Patch
https://bugs.webkit.org/attachment.cgi?id=106284&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=106284&action=review


R=me, but consider renaming suggestion

> Source/WebKit/chromium/public/WebPopupMenuInfo.h:46
> +    bool multiple;

maybe "multiple" is a little too vague here?  maybe call it
"allowMultipleSelection" or "selectMultiple"?

for example, we prefix "index" with "selected" for selectedIndex.