[webkit-reviews] review granted: [Bug 67420] Unzip initialization lists and constructors in JSCell hierarchy (5/7) : [Attachment 106274] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 67420: Unzip initialization lists and constructors in JSCell hierarchy
(5/7)
https://bugs.webkit.org/show_bug.cgi?id=67420

Attachment 106274: Patch
https://bugs.webkit.org/attachment.cgi?id=106274&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=106274&action=review


>
Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:1
0
> -    ??0DateInstance at JSC@@IAE at PAVExecState@1 at PAVStructure@1 at N@Z
> +   ??0DateInstance at JSC@@IAE at PAVExecState@1 at PAVStructure@1@@Z
>      ??0DefaultGCActivityCallback at JSC@@QAE at PAVHeap@1@@Z
>      ??0DropAllLocks at JSLock@JSC@@QAE at W4JSLockBehavior@2@@Z
> -   
??0DynamicGlobalObjectScope at JSC@@QAE at AAVJSGlobalData@1 at PAVJSGlobalObject@1@@Z  

> -   
??0InternalFunction at JSC@@IAE at PAVJSGlobalData@1 at PAVJSGlobalObject@1 at PAVStructure
@1 at ABVIdentifier@1@@Z
> +   
??0DynamicGlobalObjectScope at JSC@@QAE at AAVJSGlobalData@1 at PAVJSGlobalObject@1@@Z 
> +   ??0InternalFunction at JSC@@IAE at PAVJSGlobalObject@1 at PAVStructure@1@@Z

Indentation level seems inconsistent here.

>
Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:2
2
> -   
??0StringObject at JSC@@IAE at AAVJSGlobalData@1 at PAVStructure@1 at PAVJSString@1@@Z
> +   ??0StringObject at JSC@@IAE at AAVJSGlobalData@1 at PAVStructure@1@@Z

Indentation level seems inconsistent here.

>
Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:1
86
>      ?finalize at WeakHandleOwner@JSC@@UAEXV?$Handle at W4Unknown@JSC@@@2 at PAX@Z
> +   ?finishCreation at DateInstance@JSC@@IAEXAAVJSGlobalData at 2@N at Z
> +  
?finishCreation at InternalFunction@JSC@@IAEXAAVJSGlobalData at 2@PAVJSGlobalObject at 2
@ABVIdentifier at 2@@Z
>      ?finishCreation at JSArray@JSC@@IAEXAAVJSGlobalData at 2@@Z
>      ?finishCreation at JSArray@JSC@@IAEXAAVJSGlobalData at 2@ABVArgList at 2@@Z
>     
?finishCreation at JSFunction@JSC@@IAEXPAVExecState at 2@PAVJSGlobalObject at 2@HABVIden
tifier at 2@PAVExecutableBase at 2@@Z
>     
?finishCreation at JSObjectWithGlobalObject@JSC@@IAEXAAVJSGlobalData at 2@PAVJSGlobal
Object at 2@@Z
> +   ?finishCreation at RegExpObject@JSC@@IAEXPAVJSGlobalObject at 2@@Z
> +   ?finishCreation at StringObject@JSC@@IAEXAAVJSGlobalData at 2@PAVJSString at 2@@Z
>      ?focus at Profile@JSC@@QAEXPBVProfileNode at 2@@Z

Indentation level seems inconsistent here.