[webkit-reviews] review denied: [Bug 66524] Test how HTMLButtonElement.setCustomValidity reacts to too few arguments : [Attachment 104441] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Sep 3 14:24:56 PDT 2011
Adam Barth <abarth at webkit.org> has denied Mark Pilgrim <pilgrim at chromium.org>'s
request for review:
Bug 66524: Test how HTMLButtonElement.setCustomValidity reacts to too few
arguments
https://bugs.webkit.org/show_bug.cgi?id=66524
Attachment 104441: Patch
https://bugs.webkit.org/attachment.cgi?id=104441&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
I agree with Darin. Having a separate test for each of these functions is kind
of overkill. Can we combine them into one (or a few) tests that exercise
groups of related APIs. For example, it seems like all the setCustomValidity
tests would be better combined into a single test.
More information about the webkit-reviews
mailing list