[webkit-reviews] review granted: [Bug 67242] Don't round-trip through TransformationMatrix in SVGImageBufferTools::clearAffineTransform2DRotation : [Attachment 106215] style fix

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 67242: Don't round-trip through TransformationMatrix in
SVGImageBufferTools::clearAffineTransform2DRotation
https://bugs.webkit.org/show_bug.cgi?id=67242

Attachment 106215: style fix
https://bugs.webkit.org/attachment.cgi?id=106215&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=106215&action=review


Missmatch on chromium:	svg/custom/svg-fonts-word-spacing.html = IMAGE+TEXT
Is that related to your patch? Please check this before landing.

> Source/WebCore/platform/graphics/transforms/AffineTransform.cpp:310
> +	       srA.angle -= piDouble * 2.0;

If you are already touching the code... s/2.0/2/ for every appearance.

> Source/WebCore/platform/graphics/transforms/AffineTransform.cpp:344
> +    if (m.a() * m.d() - m.c() * m.b() < 0.0) {

s/0.0/0/

> Source/WebCore/rendering/svg/SVGImageBufferTools.cpp:130
> +    decomposition.angle = 0.0;

s/0.0/0/