[webkit-reviews] review denied: [Bug 67537] Implement a ProgressEvent constructor for JSC : [Attachment 106224] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Kentaro Hara <haraken at google.com>'s
request for review:
Bug 67537: Implement a ProgressEvent constructor for JSC
https://bugs.webkit.org/show_bug.cgi?id=67537

Attachment 106224: Patch
https://bugs.webkit.org/attachment.cgi?id=106224&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=106224&action=review


> LayoutTests/fast/events/constructors/progress-event-constructor.html:46
> +shouldBe("new ProgressEvent('eventType', { bubbles: true, cancelable: true,
lengthComputable: true, loaded: 12345, total: 12345 }).bubbles", "true");
> +shouldBe("new ProgressEvent('eventType', { bubbles: true, cancelable: true,
lengthComputable: true, loaded: 12345, total: 12345 }).cancelable", "true");
> +shouldBe("new ProgressEvent('eventType', { bubbles: true, cancelable: true,
lengthComputable: true, loaded: 12345, total: 12345 }).lengthComputable",
"true");
> +shouldBe("new ProgressEvent('eventType', { bubbles: true, cancelable: true,
lengthComputable: true, loaded: 12345, total: 12345 }).loaded", "12345");
> +shouldBe("new ProgressEvent('eventType', { bubbles: true, cancelable: true,
lengthComputable: true, loaded: 12345, total: 12345 }).total", "12345");

It might makes sense to test the edge cases for loaded or total, that is,
values	values in the range [0, 18446744073709551615] (unsigned long long
range), NaN, negative values, non-numeric values, object literals with valueOf
functions, etc.

> Source/WebCore/dom/ProgressEvent.h:66
> +    ProgressEvent(const AtomicString& type, const ProgressEventInit&
initializer);

The parameter initializer is not really needed here.