[webkit-reviews] review granted: [Bug 67510] Crash can occur when doing a PlatformCAAnimation::copy() with no valueFunction : [Attachment 106226] Patch with testcase

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Chris Marrin
<cmarrin at apple.com>'s request for review:
Bug 67510: Crash can occur when doing a PlatformCAAnimation::copy() with no
valueFunction
https://bugs.webkit.org/show_bug.cgi?id=67510

Attachment 106226: Patch with testcase
https://bugs.webkit.org/attachment.cgi?id=106226&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=106226&action=review


> LayoutTests/animations/pause-crash.html:38
> +	   setTimeout(function() {
> +	       document.getElementById('box1').style.webkitAnimationPlayState =
"paused";
> +	       setTimeout(function() {
> +		  
document.getElementById('box1').style.webkitAnimationPlayState = "running";
> +		   setTimeout(function() {
> +		       document.getElementById('results').innerHTML = 'Did not
crash, so PASSED';
> +		       if (window.layoutTestController)
> +			   layoutTestController.notifyDone();
> +		   }, 100);
> +	       }, 100);
> +	   }, 100);

Seems like you could reduce these timeouts.