[webkit-reviews] review granted: [Bug 67519] Add JSC:RegExp functional test data generator : [Attachment 106194] Proposed patch

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 67519: Add JSC:RegExp functional test data generator
https://bugs.webkit.org/show_bug.cgi?id=67519

Attachment 106194: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=106194&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
There are some 16-bit/8-bit changes that shouldn't be in this patch, please
revert.
r+, but I would prefer to see #undef REGEXP_FUNC_TEST_DATA_GEN be #define
REGEXP_FUNC_TEST_DATA_GEN 0, and the tests of it change correspondingly.