[webkit-reviews] review granted: [Bug 67342] Replace local implementation of string equals() methods with UString versions : [Attachment 106007] Real proposed patch

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 67342: Replace local implementation of string equals() methods with UString
versions
https://bugs.webkit.org/show_bug.cgi?id=67342

Attachment 106007: Real proposed patch
https://bugs.webkit.org/attachment.cgi?id=106007&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
Per our discussion, since the call sites to equal are all trivial methods we
should be able to inline these instead, removing the additional layer of
function calling & likely overall reducing the size of the binary.

r+ with Darin's comments + perf testing (particularly for JSC, since you're
changing the implementation of equal for Identifiers).