[webkit-reviews] review denied: [Bug 67229] ThreadableLoaderClient should support 'didDownloadData' updates : [Attachment 105938] Proposed Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Bill Budge
<bbudge at gmail.com>'s request for review:
Bug 67229: ThreadableLoaderClient should support 'didDownloadData' updates
https://bugs.webkit.org/show_bug.cgi?id=67229

Attachment 105938: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=105938&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=105938&action=review


> Source/WebCore/loader/ResourceLoader.cpp:577
> +#if PLATFORM(CHROMIUM)

As discussed in person, I think we should move these method implementations to
a separate file named ResourceLoaderChromium.cpp.  It should live in
loader/chromium/.
See loader/mac/ResourceLoaderCFNet.cpp for example.

Same goes for the other loader/*.cpp files in this patch.