[webkit-reviews] review granted: [Bug 67445] [Qt] number input not rendering spin buttons properly in RTL direction : [Attachment 106131] Proposed Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Jarred Nicholls
<jarred at sencha.com>'s request for review:
Bug 67445: [Qt] number input not rendering spin buttons properly in RTL
direction
https://bugs.webkit.org/show_bug.cgi?id=67445

Attachment 106131: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=106131&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=106131&action=review


r=me

> Source/WebCore/platform/qt/RenderThemeQt.cpp:1121
> +    // QPlastiqueStyle looks best when the spin buttons are flush with the
frame's edge.

You made me look up 'flush', you donkey. :)