[webkit-reviews] review denied: [Bug 67482] [CMake] Detect the operating system in a more generic way. : [Attachment 106122] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 2 06:28:32 PDT 2011


Patrick R. Gansterer <paroga at paroga.com> has denied Raphael Kubo da Costa
<kubo at profusion.mobi>'s request for review:
Bug 67482: [CMake] Detect the operating system in a more generic way.
https://bugs.webkit.org/show_bug.cgi?id=67482

Attachment 106122: Patch
https://bugs.webkit.org/attachment.cgi?id=106122&action=review

------- Additional Comments from Patrick R. Gansterer <paroga at paroga.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=106122&action=review


> Source/CMakeLists.txt:76
> +IF (UNIX)

ok

> Source/CMakeLists.txt:82
> +ELSEIF (WIN32)

WIN32 isn't defined for Windows CE!


More information about the webkit-reviews mailing list