[webkit-reviews] review requested: [Bug 66027] Implementation for "nav-up" "nav-down" "nav-left" "nav-right" properties in CSS3-UI module : [Attachment 106113] initial patch for review.

[bugzilla-daemon at webkit.org]

kyounga <kyounga.ra at gmail.com> has asked  for review:
Bug 66027: Implementation for "nav-up" "nav-down" "nav-left" "nav-right"
properties in CSS3-UI module
https://bugs.webkit.org/show_bug.cgi?id=66027

Attachment 106113: initial patch for review.
https://bugs.webkit.org/attachment.cgi?id=106113&action=review

------- Additional Comments from kyounga <kyounga.ra at gmail.com>
I know css-style are discussing on using ID selector as CSS value.
just made an initial implementation only for review.

There are several issues to be discussed in my patch
1. Changed CSSGrammar.y
    - Added IDSEL as a value, checked for #15360 issue (IDSEL was removed by
this issue.)
2. Added a new class member to RenderStyle, instead of pointer or smart
pointer.
    - Is it memory waste? less memory fragmentation? good performance? 
    - I think that this property won't be used frequently but if it is used
once, it may be used frequently in one page.

Simple unit-tests are completed.
- no "nav-*" property.
- simple "nav-*" property from CSS3-UI example.
- scrollable page.
- inherit value
- invalid target name = no work.
- target name = between two frames.