[webkit-reviews] review granted: [Bug 67443] Clean up CachedResource::load() : [Attachment 106039] patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Nate Chapin
<japhet at chromium.org>'s request for review:
Bug 67443: Clean up CachedResource::load()
https://bugs.webkit.org/show_bug.cgi?id=67443

Attachment 106039: patch
https://bugs.webkit.org/attachment.cgi?id=106039&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=106039&action=review


r=me

> Source/WebCore/ChangeLog:8
> +	   Clean up CachedResource::load().
> +	   https://bugs.webkit.org/show_bug.cgi?id=67443
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   No new tests, refactor only.

It would be good to give a short overview here how this patch makes the world a
better place.

> Source/WebCore/loader/ResourceLoaderOptions.h:60
> +    ResourceLoaderOptions(SendCallbackPolicy sendLoadCallbacksArg,
ContentSniffingPolicy sniffContentArg, DataBufferingPolicy shouldBufferDataArg,
StoredCredentials allowCredentialsArg, SecurityCheckPolicy securityCheckArg) :
sendLoadCallbacks(sendLoadCallbacksArg), sniffContent(sniffContentArg),
shouldBufferData(shouldBufferDataArg), allowCredentials(allowCredentialsArg),
securityCheck(securityCheckArg) { }

*Arg naming is not necessary, you can do : sendLoadCallbacks(sendLoadCallbacks)


> Source/WebCore/loader/ResourceLoader.cpp:122
> +    FrameLoader* fl = m_frame->loader();

fl -> frameLoader