[webkit-reviews] review granted: [Bug 67462] fix MockFileSystem.glob(), refactor filesystem tests : [Attachment 106085] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 67462: fix MockFileSystem.glob(), refactor filesystem tests
https://bugs.webkit.org/show_bug.cgi?id=67462

Attachment 106085: Patch
https://bugs.webkit.org/attachment.cgi?id=106085&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=106085&action=review


OK.

> Tools/Scripts/webkitpy/common/system/filesystem_mock.py:155
> +	   glob_string = glob_string.replace('\\*', '[^\\/]*') + '$'
> +	   glob_string = glob_string.replace('\\/', '/')
> +	   path_filter = lambda path: re.match(glob_string, path)

This is going to end up matching . in glob_string against any char.  Which is
OK, but you shoudl be aware.