[webkit-reviews] review granted: [Bug 67431] [CSS3 Backgrounds and Borders] Implement border-image-repeat : [Attachment 106024] Fix more style complaints.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Sep 1 15:06:09 PDT 2011
Beth Dakin <bdakin at apple.com> has granted Dave Hyatt <hyatt at apple.com>'s
request for review:
Bug 67431: [CSS3 Backgrounds and Borders] Implement border-image-repeat
https://bugs.webkit.org/show_bug.cgi?id=67431
Attachment 106024: Fix more style complaints.
https://bugs.webkit.org/attachment.cgi?id=106024&action=review
------- Additional Comments from Beth Dakin <bdakin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=106024&action=review
> Source/WebCore/css/CSSParser.cpp:5373
> + if (isBorderImageRepeatKeyword(val->id))
Maybe I am reading this wrong, but it seems like this would read clearer as:
if (isBorderImageRepeatKeyword(val->id))
return false;
firstValue = primitiveValueCache()->createIdentifierValue(val->id);
More information about the webkit-reviews
mailing list