[webkit-reviews] review denied: [Bug 67174] Unzip initialization lists and constructors in JSCell hierarchy (4/7) : [Attachment 106010] Random improvement

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 67174: Unzip initialization lists and constructors in JSCell hierarchy
(4/7)
https://bugs.webkit.org/show_bug.cgi?id=67174

Attachment 106010: Random improvement
https://bugs.webkit.org/attachment.cgi?id=106010&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=106010&action=review


Hmmm, there are no changelogs :-(

> Source/JavaScriptCore/runtime/InternalFunction.cpp:47
> +    finishCreation(*globalData, globalObject, name);

Is it intentional the InternalFunction retains the finishCreation in its
constructor?