[webkit-reviews] review denied: [Bug 60170] [Chromium] Speech-enabled input fields need the ability to trigger without a click : [Attachment 106005] Patch for landing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 1 13:25:43 PDT 2011


Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Dominic Mazzoni
<dmazzoni at google.com>'s request for review:
Bug 60170: [Chromium] Speech-enabled input fields need the ability to trigger
without a click
https://bugs.webkit.org/show_bug.cgi?id=60170

Attachment 106005: Patch for landing
https://bugs.webkit.org/attachment.cgi?id=106005&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=106005&action=review


Sorry, I have an extra nit! :)

> Source/WebCore/html/shadow/TextControlInnerElements.cpp:527
> +    RefPtr<HTMLInputElement>
input(static_cast<HTMLInputElement*>(shadowAncestorNode()));

use input = foo syntax instead.


More information about the webkit-reviews mailing list