[webkit-reviews] review denied: [Bug 67395] [Chromium, Skia] Add virtual to WebGraphicsContext3D to create a new GrGLInterface per context. Insert per-skia-GL-function callback to set correct GL context. : [Attachment 105952] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied Brian Salomon
<bsalomon at google.com>'s request for review:
Bug 67395: [Chromium, Skia] Add virtual to WebGraphicsContext3D to create a new
GrGLInterface per context. Insert per-skia-GL-function callback to set correct
GL context.
https://bugs.webkit.org/show_bug.cgi?id=67395

Attachment 105952: Patch
https://bugs.webkit.org/attachment.cgi?id=105952&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=105952&action=review


Sorry, but I have to r- this because the license needs to be updated in the new
file. Also CC'ing fishd as he should review all WebKit API changes. It looks OK
overall to me though.

> Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp:166
> +	   // remove this block after WGC3D subclasses in Chromium overriding
using grGLInterface()

Add FIXME and please make this comment and the one below a complete sentence.

> Source/WebKit/chromium/src/WebGraphicsContext3D.cpp:15
> + *	  from this software without specific prior written permission.

Sorry, this is the wrong version of the license file. I know there are a ton of
files that have this license but we should avoid adding more that are wrong.
Please derive the license text from Source/WebKit/LICENSE, or see e.g.
Source/WebKit/chromium/tests/PODIntervalTreeTest.cpp.