[webkit-reviews] review denied: [Bug 66228] REGRESSION (NRWT): Leaks Viewer can't load leaks from test runs that used NRWT : [Attachment 105995] Fix typo from Darin's review

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has denied Eric Seidel <eric at webkit.org>'s
request for review:
Bug 66228: REGRESSION (NRWT): Leaks Viewer can't load leaks from test runs that
used NRWT
https://bugs.webkit.org/show_bug.cgi?id=66228

Attachment 105995: Fix typo from Darin's review
https://bugs.webkit.org/attachment.cgi?id=105995&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=105995&action=review


> Tools/ChangeLog:19
> +	   * Scripts/webkitpy/layout_tests/port/test.py:

Nit. Doesn't look like you're actually changing port/test.py?

> Tools/Scripts/webkitpy/common/system/filesystem_mock.py:154
> +	   # We could use fnmatch.fnmatch, but that might not do the right
thing on windows.

Can you try my re.match suggestion instead ? If that passes the tests, I'd
prefer we do that, as the code is likely much cleaner than this (and will
handle more cases to boot).