[webkit-reviews] review denied: [Bug 60451] speech input doesn't fire textInput events : [Attachment 105934] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 1 11:01:54 PDT 2011

Ryosuke Niwa <rniwa at webkit.org> has denied Leandro Graciá Gil
<leandrogracia at chromium.org>'s request for review:
Bug 60451: speech input doesn't fire textInput events

Attachment 105934: Patch

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=105934&action=review

> Source/WebCore/dom/TextEvent.idl:44
> +	   readonly attribute unsigned long inputMethod;

Adding this property to TextEvent should be done in a separate patch, or else
you should describe the change in your change log and point to the appropriate
spec. r- because of this.
Also, if you're adding this property, then you'll need to test every one of
those values you're adding.  Furthermore, this is a new feature, so you should
be announcing it on webkit-dev.

More information about the webkit-reviews mailing list