[webkit-reviews] review granted: [Bug 58369] Add 'muted' content attribute to HTMLMediaElement : [Attachment 105981] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Sep 1 10:16:39 PDT 2011
Darin Adler <darin at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 58369: Add 'muted' content attribute to HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=58369
Attachment 105981: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=105981&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=105981&action=review
> Source/WebCore/html/HTMLMediaElement.idl:81
> + attribute boolean defaultMuted;
If you wrote this:
attribute [Reflect=muted] boolean defaultMuted;
Then you would not need to add the HTMLMediaElement::defaultMuted and
HTMLMediaElement::setDefaultMuted functions. How about doing it that way?
More information about the webkit-reviews
mailing list